ioNiNJA ALPHA

[Yil]

Think I found a bug in ioFTPD while debugging a site for someone, but it also needs a script fix. Looks like you need to [catch] protect the [ioftpd user get] calls in get_stats in Ninja/njTQ and the one in get_uinfo in njTQ. I may have a bug where deleted/purged users aren't forcing the write to UserIdTable correctly which means the bot is trying to lookup users who don't exist. Evidently catching "" isn't good enough. While this probably won't be a big deal after I fix the server bug there will always be race conditions with newly purged users so probably need to handle it.

[o_dog]

can check it out, njtq needs a rewrite though, jsut havn't had the time nor energy to do so.

[KingRas]

running ioftpd 6.2.1 and the nwest ninja i get those any idead and resloving.
i dont get complete tags or anthing damn uploads all fail.

-------------------------- ErrorInfo ----------------------------
invalid command name "lassign"
while executing
"lassign [vfs read $file] uid gid mode"
(procedure "::ioNiNJA::ZipScript::ZipScript" line 19)
invoked from within
"::ioNiNJA::ZipScript::ZipScript 0 [lindex $args 1] [lindex $args 2] [lindex $args 3] "
("CHECK" arm line 1)
invoked from within
"switch -- [lindex $args 0] {
SYMCLEAN {
set temp [userfile o08-02-2009 22:36:48 "..\scripts\ioNiNJA\ioNiNJA.itcl" terminated abnormally
--------------------------- ErrorInfo ----------------------------
invalid command name "::ioNiNJA::CWD"
while executing
"::ioNiNJA::CWD "
("CWD" arm line 1)
invoked from within
"switch -- [lindex $args 0] {
SYMCLEAN {
set temp [userfile open [resolve uid [lindex [user list] 0]]]
set temp [mountfile open ../etc/defaul..."
(file "..\scripts\ioNiNJA\ioNiNJA.itcl" line 913)
--------------------------------------------08-02-2009 22:37:14 "..\scripts\ioNiNJA\ioNiNJA.

[o_dog]

ioninja is not designed for old versions of ioftpd

[KingRas]

Thx i'll try 7.0

[opcode]

For some odd reason, output is totally fubar here. I used to work with ioFTPD 6.9.3 and some older ioNiNJA version. I updated to ioFTPD 7.0.1 and ioNiNJA BETA Stable v0.8.9.6 2009-06-29 and now suddenly get this.

1st 15mb file uploaded

[2] 226-.----== ioNiNJA v0.8 ==----------------------------.
[2] 226-| + CRC-Check: oK!                                 |
[2] 226-+-=[UserTop]=-------------------===----------------+
[2] 226-|  1. testuser             663KB  100F     1.0KB/s |
[2] 226-+-=[GroupTop]=--------------------===--------------+
[2] 226-|  1. 14648                663KB  100F     1.0KB/s |
[2] 226-`-[----------]--------------------[   1F / 11F  ]--'

2nd file

[2] 226-.----== ioNiNJA v0.8 ==----------------------------.
[2] 226-| + CRC-Check: oK!                                 |
[2] 226-+-=[UserTop]=-------------------===----------------+
[2] 226-|  1. testuser             267KB 2550F    51.0KB/s |
[2] 226-+-=[GroupTop]=--------------------===--------------+
[2] 226-|  1. 15311                267KB 2550F    51.0KB/s |
[2] 226-`-[#---------]--------------------[   2F / 11F  ]--'

3rd file

[2] 226-.----== ioNiNJA v0.8 ==----------------------------.
[2] 226-| + CRC-Check: oK!                                 |
[2] 226-+-=[UserTop]=-------------------===----------------+
[2] 226-|  1. testuser             285KB 37800     1.1MB/s |
[2] 226-+-=[GroupTop]=--------------------===--------------+
[2] 226-|  1. 14915                285KB 37800     1.1MB/s |
[2] 226-`-[##--------]--------------------[   3F / 11F  ]--'

4th file

[2] 226-.----== ioNiNJA v0.8 ==----------------------------.
[2] 226-| + CRC-Check: oK!                                 |
[2] 226-+-=[UserTop]=-------------------===----------------+
[2] 226-|  1. testuser             596KB 40690    15.9MB/s |
[2] 226-+-=[GroupTop]=--------------------===--------------+
[2] 226-|  1. 14929                596KB 40690    15.9MB/s |
[2] 226-`-[###-------]--------------------[   4F / 11F  ]--'

I didn't modify the default theme but just installed everything just as described.

More info:

It gives me the same behaviour with the .cfg file that comes with the script. Also the complete screen has the correct files/size/speed but not the group (complete screen from another testrun then above, so filecount/size differs)

[2] .-----------------====--------------------------== ioNiNJA v0.8 ===--.
[2] |                                                                    |
[2] |-=[ R A C E N F O ]=---------------.                                |
[2] |                                    `-----------------====----------|
[2] | Release: Some_test_dir_here                                     |
[2] | RaceNfo: 12MB in 3F @ 75.0KB/s in 2m 47s                           |
[2] | Fastest: testuser/ @ 117.0KB/s                                     |
[2] | Slowest: testuser/ @ 75.0KB/s                                      |
[2] |                                                                    |
[2] |-=[ U S E R T O P ]=---------------.                                |
[2] |                                    `-----------------====----------|
[2] |  1. testuser                     75KB      3780   2%      1.1MB/s |
[2] |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - |
[2] |  1. Total                         12MB      3F     100%   75.0KB/s |
[2] |                                                                    |
[2] |-=[ G R O U P T O P ]=-------------.                                |
[2] |                                    `--------------===--------------|
[2] |  1. 2848                          75KB      3780   %       1.1MB/s |
[2] |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - |
[2] |  1. Total                         12MB      3F     100%   75.0KB/s |
[2] `-----================---------------------------==------------------'

testuser is added to group TEST, site myinfo shows

[2] 200-| Username : testuser             | User ID : 7      Primary GID: 256   |
[2] 200-| Flags    : 3                      | Last On : 4m 40s ago                |
[2] 200-| Groups   : TEST                                                      |
[2] 200-| Tagline  :                                                              |
[2] 200-| Creator  : siteop               | Created : 10m 1s ago                |

[opcode]

I figured it out. set ioNJ(hide_gname_real) was set to 0, but i actually had the ioFTPD group deleted, so that broke something. I disabled the feature and now everything works like a charm.

[isteana]

i have an experienced the same problem and that was made me crazy for few hours
that seems useless buggy option. should be turn off

[o_dog]

istena: stupidity is not really a bug

[o_dog]

i guess there are no serious bugs left?

[Dahlia]

Originally Posted by o_dog

i guess there are no serious bugs left?

Looks like zipscript is mainly working great! with 7.x and latest beta of ioninja i never gets any weird error like before with releases where were all files but 'incomplete' tag. now everything works fine.

I just found some minor bugs:
1. SAMPLE
- when SAMPLE is uploaded and $v_width is higher than 999 ('1 280' etc,...), than script sends wrong info to ioftpd.log (only first number '1').
- when SAMPLE is VOB file than script sends always N/A info for $v_codec. and sometimes instead of AC-3 or MPEG -Audio or PCM he sends to ioftpd.log 'DVD-Video' as $a_codec
Strange is that .message file in SAMPLE dir is always filled with right info, only main dir message and info in ioftpd.log is contains wrong info.

2. I'm using imdb.itcl plugin in event "EXEC ON NFO UPLOAD" and sometimes he gets no info from imdb.com. And its not because imdb.com is unreacheable. Just all variables are 'N/A' when i upload nfo again few seconds after he gets all infos right. So some delay, or if he get N/A %title from imdb.com than run script again, can fix that, dunno.

3. Settings: set ioNJ(custom_group_dirs_complete_message) "../scripts/ioNiNJA/MiSC/group_dir_message.nfo" work fine only when PREd rls is 2CD or more. if the rls is only 1CD so files are in main dir than there is no message.nfo after PRE.


And please, if i can have few requests on you. i Want to ask you to change few things please:
r1 - I will be glad to have uid/gid of 'Complete Tag in rls' changes to any uploader uid/gid - best will be the one who complete rls. Now is uid and gid of this "[site] - ( 242MB 6F - COMPLETE ) - [site]" UID 0 and GID 0 (so default ioftpd user) and if autoscript nuke this rls there is always info - autonuker script nuked: ioFTPD/ioFTPD and 'some uploader'. all files in rls dir might be chown to uploaders
r2 - I will be glad to have another option/event for plugins in ioninja.cfg. There is now 'exec on nfo upload, exec on complete' and im looking for some 'on 'site PRE''. want to add imdb.itcl plugin after site pre in dvdr/divx etc, dirs. or please tell me how to do that with current script.
r3 - i didnt find how to set that in current version of your script but now 'Complete tag' is only when nfo is also in rls and rls should be with 'Complete tag' even without .nfo file - for *.nfo missing info is enough to see missing-nfo 'symlink'.

and request 4 is related to nxTools since you are mby the only one who can do it something with that script atm.
there is option in nxtools.cfg:
# - The user ID to chown all files too, to hide an affil's identity (to disable, set to "").
set pre(ChownUserId) "1"
This is a nice option for PRE groups but now it is useless since there is no option to hide owner of PRE'd dirs, only files. So after pre everyone can see who uploaded CD1,Sample and also main dir is chown to uploader. only files uid is changed


Thank you for answer. And thanks for this great script.

[razoor]

The pre (ChownUser) should be set to "0"
So that works without any problem in nxtools.
The group is chown when pre´d and not the user if you have set it correct in ioninja to.

[Dahlia]

Originally Posted by razoor

The pre (ChownUser) should be set to "0"
So that works without any problem in nxtools.
The group is chown when pre´d and not the user if you have set it correct in ioninja to.

Sorry, maybe i didnt said exactly in my sentence what is the problem. So once again.

Uid '1' in my user db is user named 'pre'. Uid '0' is ioFTPD. I can try to change that pre UID in nxtools.cfg to '0' but i don't think that will change UID of PRE'd dirs. Because UID 1 from config changed all PRE'd files uid to 1, but uid of PRE'd dirs was still uid of uploader.

I want to have after PRE -> UID of all files/dirs in PRE'd release changed to something what i define in nxtools.cfg. Now that settings "set pre(ChownUserId)" change only files uid and not dirs.

[razoor]

well this does work without any problem here.

in ioninja
set ioNJ(hide_group_uploaders) 1
set ioNJ(hide_uname) "pre"
set ioNJ(hide_gname) "pre"
This group and user has to exist

So when you upload to \PRE\TFT\
The race info and owner on the files will be pre

Then when you do site pre the race info and owner on the files/folder will be pre TFT

[Dahlia]

Originally Posted by razoor

well this does work without any problem here.

in ioninja
set ioNJ(hide_group_uploaders) 1
set ioNJ(hide_uname) "pre"
set ioNJ(hide_gname) "pre"
This group and user has to exist

So when you upload to \PRE\TFT\
The race info and owner on the files will be pre

Then when you do site pre the race info and owner on the files/folder will be pre TFT

impossible,...

(taken from original ioninja.cfg)
## Hide name of uploaders in the .message-file in group-dirs? Setting this to
## 1 will convert the username to the groupname of the user. This will not
## change owner of files since it can create problems with permissions. Have the pre
## script change that instead.
set ioNJ(hide_group_uploaders) 1
set ioNJ(hide_uname) "NoUSER"
set ioNJ(hide_gname) "NoGROUP"

and this work exactly how its written in this cfg. hiding user/group only in .message. not owner of files "Have the pre script change that instead." And for that is nxtools and there you can hide only files and not dirs.


Anyway i found another 'minor bug' in dzsbot/topstats.tcl stats:

(23:45:28) (@user) !site dayup
(23:45:29) (@bot) .----------------------------------------------------.
(23:45:29) (@bot) | Day Top Uploaders |
(23:45:30) (@bot) | Section # -1 : [TOTAL] |
(23:45:30) (@bot) |----------------------------------------------------|
(23:45:30) (@bot) | ## | User | Group | Size(MB) | Files |
(23:45:31) (@bot) |----------------------------------------------------|
(23:45:33) (@bot) | 01 | user3 | ioFTPD | 10076 | 148 |
(23:45:35) (@bot) |------------------------------|----------|----------|
(23:45:37) (@bot) | 01 Total Matches | 10076 | 148 |
(23:45:39) (@bot) '----------------------------------------------------'
(23:45:41) (@bot) 'stats' Command successful.
(23:45:44) (@user) !dayup user3
(23:45:45) (@bot) (SITE-STATS) user3 is 1st with 148F and 10MB, followed by user2 with 0F and 0KB

(23:48:25) (@user) !site daydn
(23:48:27) (@bot) .----------------------------------------------------.
(23:48:27) (@bot) | Day Top Downloaders |
(23:48:27) (@bot) | Section # -1 : [TOTAL] |
(23:48:27) (@bot) |----------------------------------------------------|
(23:48:28) (@bot) | ## | User | Group | Size(MB) | Files |
(23:48:30) (@bot) |----------------------------------------------------|
(23:48:32) (@bot) | 01 | user1 | ioFTPD | 2021 | 146 |
(23:48:34) (@bot) | 02 | user2 | ioFTPD | 1267 | 108 |
(23:48:36) (@bot) |------------------------------|----------|----------|
(23:48:38) (@bot) | 02 Total Matches | 3288 | 254 |
(23:48:40) (@bot) '----------------------------------------------------'
(23:48:42) (@bot) 'stats' Command successful.
(23:48:44) (@user) !daydn user1
(23:48:44) (@bot) (SITE-STATS) user1 is 1st with 146F and 2.0GB, followed by user2 with 108F and 2MB


(23:54:26) (@bot) Daystats for SOMESiTE, today we:
(23:54:26) (@bot) * Recieved 148 files totalling 10.0GB
(23:54:26) (@bot) * Sent 254 files totalling 3.2GB
(23:54:26) (@bot) * Had 1469 logins and 1469 logouts.
(23:54:26) (@bot) * Created 9 new release-dirs, but deleted 7 directories.
(23:54:28) (@bot) * Made 0 new requests, and filled 0.
(23:54:30) (@bot) * Had some prominent racers, the top ones were:
(23:54:32) (@bot) +[1] user3 (10MB/148f)
(23:54:34) (@bot) +[2] user2 (0KB/0f)
(23:54:36) (@bot) * Had some nasty leeches, the nastiest ones were:
(23:54:38) (@bot) +[1] user1 (2.0GB/146f)
(23:54:40) (@bot) +[2] user2 (2MB/108f)
(23:54:42) (@bot) +[3] user4 (0KB/0f)
(23:54:44) (@bot) * Got 0 glorious pres, the groups with the most pres were:

All day i tested what stats we getting from dzsbot and topstats script and its weird. Dzsbots !dayup (probably all other stats !cmds too) and topstats.tcl showing sometimes wrong info from user stats. Halp! :-)



p.s.
still looking for an active scripter who could help me to fix those bugs