quit handling while in file transfer

[robe]

hi!

it seems as if flashfxp (build 836 over here) doesn't handle quits correctly while transferring a file

if you press "disconnect" while transferring a file, flashfxp waits till the send buffer is emptied, then dispatches a "quit" to the server (which arrives at the serverside) and then immediately kills the control connection, leaving the server no chance to send the 221 response, which will result in a ghost connection on the server side.

this was testet with proftpd 1.2.5rc2

[MxxCon]

that's why you should use ABORT and then disconnect.

in some cases you actualy have to just drop connection, so think current way is fine.

and btw, upgrade alot of things were improved since 835.

[robe]

it's not fixed in 849 either..

the current behaviour is a violation of the rfc so it can't be right (when there's no transfer running flashfxp "behaves" right, waiting for the 221 response from the server before killing of the control connection).

i agree with you that there may be situations where you just want to kill of the data connection (e.g. remote server went dead); what about making the first click on "disconnect" a soft disconnect, and the second abruptively closing the data and control connections?

[bigstar]

Originally posted by robe
it's not fixed in 849 either..

the current behaviour is a violation of the rfc so it can't be right (when there's no transfer running flashfxp "behaves" right, waiting for the 221 response from the server before killing of the control connection).

I'll look into that.

i agree with you that there may be situations where you just want to kill of the data connection (e.g. remote server went dead); what about making the first click on "disconnect" a soft disconnect, and the second abruptively closing the data and control connections?

That's exactly how it works. The first click sends QUIT, the second forces disconnect.

[Jesper]

About this "ghost" problem there obviously is in FFXP

Could the problem also occur if the client looses his connection e.g pings/times out ? and that way leave a ghost on the FTPd that he is uploading to ?

[MxxCon]

yes, it's possible if connection didn't time out soon enough.
many ftpd support special login something like "-username" or "username!" that will kill ghost connections.

[bigstar]

Originally posted by robe
it seems as if flashfxp (build 836 over here) doesn't handle quits correctly while transferring a file

After further investigation you appear to be correct, I'm not entirely sure why but the code that sends abort on disconnect was commented out. I have re-activated it.