FlashFXP doesn't prompt for a password again

Hi,

I am using 4.4.0 #1997 and I think this is a regression, but I am not 100% sure:

If you have a profile which should prompt you for password, the password will be saved for this session, even if you have entered the wrong password.

To reproduce:

1. Start FlashFXP
2. Create a server profile
   • SFTP over SSH (but should affect normal FTP, too)
   • Prompt for password
   • Specify a username
   • Do not specify a password!
3. Connect to that profile
4. Enter the wrong password when FlashFXP will prompt for password
5. Connection will fail as expected
6. Now you are unable to connect to that server profile again, because FlashFXP has saved the wrong password and will never prompt again until you restart FlashFXP.

What I expect:
It is OK for me, that FlashFXP will save the password for the session. But only when the password is right! I expected something like that:

1. You connect to a system which will prompt you for password
2. You enter the wrong credentials
3. FlashFXP should prompt again

and also

1. You connect to a system which will prompt your for password
2. You enter currently working credentials
3. FlashFXP is able to connect and will now save the password for that session.
4. You disconnect (but FXP won't be closed).
5. You change the password from the used credentials on server.
6. You reconnect - FlashFXP will use the previous saved credentials which will fail now
7. FlashFXP should now prompt for new credentials

Oh woah thank you for bringing this to my attention.

This issue appears to be specific to SFTP servers and is caused by flawed logic used to detect an invalid password during login.

Please try this and let me know if it resolves the problem.
FlashFXP44_1998_Setup.exe

That was fast

Yup, your new build fixes the problem. Bot cases are working now as expected. Thanks!

Thank you for confirming the fix. I have pushed out a new build with the changes.