FlashFXP hangs when reconnecting.

Hi.

After upgrading to build 1667 my FlashFXP hangs every time I try to connect more than once.

To reproduce the issue connect to a site, disconnect and then reconnect to the same site.

FlashFXP then goes into some unresponsive state, and seems to be using a hell of a lot of CPU.

I am running Windows XP with SP3, and have no issues with build 1664.

rco133

ACK on this bug.

After today's update fxp hangs after reconnect.

System: Windows 7 64Bit, all actual patches/updates installed.
Also verified on: Windows 7 32Bit, Windows XP 32Bit

Confirm it!

I'm not sure why this hanging is occurring, I did not see this behavior in my testing.

What protocol are you using to connect to the server? (FTP, FTP+SSL, SFTP)

When you disconnect from the server is FlashFXP fully logged in?

Are you connecting to the server via a proxy server?

Are you reconnecting to the same site or a new site?

When the hang occurs what is the last line of text in the session status window?

Ok,

i connected to a server with standard ftp settings (just username+pass+server)
then i clicked the disconnect button. and there the hanging starts.

Last line is :
[R] 221 Goodbye.
[R] Ausgeloggt: ****.de

Ausgeloggt -> Logged out
*** for servername

After this the FlashFXP.exe hangs at ~13% CPU usage (i7-2630QM, 8 Cores), Mem usage is around 14MB and isnt changing.

I believe the issue is now resolved, can you please test the following fix.

[Link removed] Please download via Live Update.

The issue was caused by a rather unusual situation.

On the connection menu we trim the site name on the "reconnect: <site>" menu entry by measuring the width of the text and trimming it to fit the width of the menu.

A week ago it was brought to my attention that the original method used for trimming did not use the menu font for measurements, instead it was using the application font, which can be quite different. In 1667 this was changed to use the menu font and was thoroughly tested or so I thought.

I haven't been able to determine the exact cause but I believe that in some cases the returned font is either invalid or incorrect, which results in an end-less measure and trim loop. To remedy the problem I have added a safe guard to avoid the end-less loop and fall back to the old method which doesn't use the menu font.

Please let me know if this resolves the problem.

I will publish this build via Live Update as soon as I can get more people to confirm the fix.

Thank you

P.S. This build also includes a fix for bug #602 (tree navigation bug)

Hi.

I have just upgraded to 1668, and the issue I had with reconnecting to sites have gone away. It looks like it is working the way it did before.

rco133

Thank you for the update.

The fix is now available via Live Update.