Transfer fails on particular condition

Hi Bigstar,

there is a bugs on FlashFXP (from build 1337 to build 1345)

How to reproduce:

- connect to a FTP Server with "Cache Directories" enable
- browse some folder and see them cached
- select 50 or more files (just to have more download time) to download from the same folder
- start the download
- all works fine
- but if during transfer, navigate to others cached folders the transfer fails

I hope this could help you to debug the problem, or I'll try to be more detailed.

Regards

Miki

how does it fail? post session log

Originally Posted by MxxCon

how does it fail? post session log

I attach the session log, but it's useless ... nothing logged
flashfxp.log

Here more datailed instruction how to reproduce:

- initial situation:


- browse cached directory during a transfer (see flashfxp.log):

[11.23.27] [R] RETR Copia (5) di Nuovo Documento di testo.txt
[11.23.28] [R] 150 Opening ASCII mode data connection for Copia (5) di Nuovo Documento di testo.txt (202300 bytes)

During this transfer I navigate the cached directory and I moved to the parent folder "/WA/"
and after this transfer completed, the other transfers fails.
It look like the remote folder lost the relative path and so the transfer fail, but no errors in the log ...

[11.23.29] [R] 226 Transfer complete.
[11.23.29] Transferred: Copia (5) di Nuovo Documento di testo.txt 204.323 bytes in 0,97 seconds (206,1 KB/s)

- final result:



Regards

Miki

You stated that there is no error in the log, this is quite puzzling and is making it very difficult to determine the cause of the problem.

I did many tests and at first I was not able to reproduce the problem, then I started reviewing the code to see what was going on and then I found the problem.

I included a call to a procedure that updates the internal file list during file transfer, however if the active folder is not the same folder then the internal list is populated with the wrong content. This in turn results in a problem because there is no checking on this list, it assumes that all files being transferred exist within the list, when the file wasn't found it failed.

I need to look into a few things and I'll post a fixed build either later today or tomorrow.

I think you have found the problem, but I have done a small video with CamStudio

http://miki975.interfree.it/FlashFXP/flashfxp.swf.html

Regards

Miki

It turns out there were multiple issues related to this problem. I'm still testing to make sure everything is working properly so a fixed will be slightly delayed.

Here's the fixes I'm working on.

1. Navigating to a cached folder during transfer incorrectly cleared an internal list used for storing the file size/date, when FlashFXP went to retrieve the info from the internal list an error occurred because the information was gone.

2. Added additional checks around an internal list used for file size/date lookups.

3. When parsing the date/time reply from the MLST command the wrong conversion was performed causing the time to sometimes be wrong.

With FlashFXP v3.7.9 build 1346 [BETA] this bug is fixed

Thanks bigstar

Miki

IMO is fixed.