Flashfxp CRASH on client cert import

Hi,


I noticed that since you added the "replace" option for client certs, I'm now unable to import any new certificates. When I do flashfxp crashes. It also crashes when I try to replace an old cert with a new one.

I have tested this with 3.8 beta from the main download page. (But I noticed the problem is also in 3.6.1.1256)
I used a privatekey.pem and a cert.pem.

The bugreport says: invalid password exception, but my password is certainly valid. I tested this with several certs.

I also saw that you have an option to import p12/pfx files. I tried that option, but it doesn't work. A p12/pfx file contains both the cert and the private key in 1 file. This is just a minor note, I'm ussually not using the p12/pfx files for ftp. Just wanted to let you know that it does not seem to work.

Oh btw we bought already one license for the good support we received.
I wonder if we can expand that license later for multiple users ?


I have the bugreport below:

date/time : 2008-07-24 10:11
computer name : WS52
user name : JGO
remote session : FALSE
IsAdmin : TRUE
operating system : Windows 2003 x64 Service Pack 2 build 3790
system language : Dutch
system up time : 3 days 21 hours
program up time : 59 seconds
processors : 4x Intel(R) Xeon(R) CPU 5160 @ 3.00GHz
physical memory : 5902/8191 MB (free/total)
free disk space : (C 33,01 GB
display mode : 1680x1050, 16 bit
monitors : 1, 1680x1050
process id : $77c4
allocated memory : 19,08 MB
executable : FlashFXP.exe
executable hash : 1EF43C93E6AE0EF3FE0044894D4F1EB3
executable size : 3904184
exec. date/time : 2008-07-24 09:40
version : 3.7.2.1266
madExcept version : 2.7k
exception class : EElPublicKeyCryptoError
exception message : Invalid passphrase.

main thread ($7664):
00568fc3 FlashFXP.exe SBPublicKeyCrypto 3899 +16 TElRSAKeyMaterial.LoadSecret
0056208e FlashFXP.exe SBX509 3931 +28 TElX509Certificate.LoadKeyFromBuffer
0056211c FlashFXP.exe SBX509 3952 +12 TElX509Certificate.LoadKeyFromStream
00647251 FlashFXP.exe CreateCertDlg 639 +74 TFrmCreateCert.bImp2Click
004784ea FlashFXP.exe Controls 4294 +9 TControl.Click
0046326f FlashFXP.exe StdCtrls 2869 +3 TButton.Click
0046337b FlashFXP.exe StdCtrls 2921 +1 TButton.CNCommand
00478355 FlashFXP.exe Controls 4233 +37 TControl.WndProc
0047ab8a FlashFXP.exe Controls 5698 +42 TWinControl.WndProc
004631db FlashFXP.exe StdCtrls 2849 +13 TButtonControl.WndProc
00478184 FlashFXP.exe Controls 4158 +5 TControl.Perform
0047acfb FlashFXP.exe Controls 5741 +6 DoControlMsg
0047b1ff FlashFXP.exe Controls 5917 +1 TWinControl.WMCommand
00478355 FlashFXP.exe Controls 4233 +37 TControl.WndProc
0047ab8a FlashFXP.exe Controls 5698 +42 TWinControl.WndProc
0047a814 FlashFXP.exe Controls 5571 +3 TWinControl.MainWndProc
004685a0 FlashFXP.exe Forms 1484 +8 StdWndProc
7d948831 user32.dll SendMessageW
7d952e1c user32.dll CallWindowProcA
0047ac7f FlashFXP.exe Controls 5720 +18 TWinControl.DefaultHandler
004788f0 FlashFXP.exe Controls 4441 +1 TControl.WMLButtonUp
00478355 FlashFXP.exe Controls 4233 +37 TControl.WndProc
0047ab8a FlashFXP.exe Controls 5698 +42 TWinControl.WndProc
004631db FlashFXP.exe StdCtrls 2849 +13 TButtonControl.WndProc
0047a814 FlashFXP.exe Controls 5571 +3 TWinControl.MainWndProc
004685a0 FlashFXP.exe Forms 1484 +8 StdWndProc
7d94ab81 user32.dll DispatchMessageA
00471117 FlashFXP.exe Forms 6900 +34 TApplication.ProcessMessage
0047114e FlashFXP.exe Forms 6938 +1 TApplication.HandleMessage
0046e313 FlashFXP.exe Forms 4819 +22 TCustomForm.ShowModal
00654b3c FlashFXP.exe SiteManager 3281 +4 TFrmSite.bcertClick
004784ea FlashFXP.exe Controls 4294 +9 TControl.Click
0046326f FlashFXP.exe StdCtrls 2869 +3 TButton.Click
0046337b FlashFXP.exe StdCtrls 2921 +1 TButton.CNCommand
00478355 FlashFXP.exe Controls 4233 +37 TControl.WndProc
0047ab8a FlashFXP.exe Controls 5698 +42 TWinControl.WndProc
004631db FlashFXP.exe StdCtrls 2849 +13 TButtonControl.WndProc
00478184 FlashFXP.exe Controls 4158 +5 TControl.Perform
0047acfb FlashFXP.exe Controls 5741 +6 DoControlMsg
0047b1ff FlashFXP.exe Controls 5917 +1 TWinControl.WMCommand
00478355 FlashFXP.exe Controls 4233 +37 TControl.WndProc
0047ab8a FlashFXP.exe Controls 5698 +42 TWinControl.WndProc
0047a814 FlashFXP.exe Controls 5571 +3 TWinControl.MainWndProc
004685a0 FlashFXP.exe Forms 1484 +8 StdWndProc
7d948831 user32.dll SendMessageW
7d952e1c user32.dll CallWindowProcA
0047ac7f FlashFXP.exe Controls 5720 +18 TWinControl.DefaultHandler
004788f0 FlashFXP.exe Controls 4441 +1 TControl.WMLButtonUp
00478355 FlashFXP.exe Controls 4233 +37 TControl.WndProc
0047ab8a FlashFXP.exe Controls 5698 +42 TWinControl.WndProc
004631db FlashFXP.exe StdCtrls 2849 +13 TButtonControl.WndProc
0047a814 FlashFXP.exe Controls 5571 +3 TWinControl.MainWndProc
004685a0 FlashFXP.exe Forms 1484 +8 StdWndProc
7d94ab81 user32.dll DispatchMessageA
00471117 FlashFXP.exe Forms 6900 +34 TApplication.ProcessMessage
0047114e FlashFXP.exe Forms 6938 +1 TApplication.HandleMessage
0047136e FlashFXP.exe Forms 7028 +21 TApplication.Run
006d479d FlashFXP.exe FlashFXP 680 +509 initialization

thread $6b40:
7d61d051 ntdll.dll

thread $7894 (TChangeHandlerThread):
7d61d051 ntdll.dll
7d4e2866 kernel32.dll WaitForMultipleObjectsEx
7d4e3e89 kernel32.dll WaitForMultipleObjects
005ebb8d FlashFXP.exe UPTShellControls 4034 +11 TChangeHandlerThread.Execute
0044cf96 FlashFXP.exe madExcept HookedTThreadExecute
0041b1e0 FlashFXP.exe Classes 6905 +1 ThreadProc
00403fbc FlashFXP.exe System ThreadWrapper
0044cec9 FlashFXP.exe madExcept CallThreadProc
0044cf0b FlashFXP.exe madExcept ThreadExceptFrame
>> created by main thread ($7664) at:
005eb853 FlashFXP.exe UPTShellControls 3930 +2 TChangeHandlerThread.Create

thread $209ac:
7d61cca8 ntdll.dll

thread $7d98:
7d61c8a0 ntdll.dll

thread $7dcc:
7d61c8a0 ntdll.dll

modules:
00400000 FlashFXP.exe 3.7.2.1266 C:\Program Files (x86)\FlashFXP
007f0000 ADVAPI32.dll 5.2.3790.3959 C:\WINDOWS\syswow64
00890000 oleaut32.dll 5.2.3790.4202 C:\WINDOWS\syswow64
00920000 SHLWAPI.dll 6.0.3790.3959 C:\WINDOWS\syswow64
02af0000 ssleay32.dll 0.9.8.8 C:\Program Files (x86)\FlashFXP
03620000 mkunicode.dll C:\Program Files (x86)\The FilmMachine\Filters
03640000 mmfinfo.dll C:\Program Files (x86)\The FilmMachine\Filters
03680000 xpsp2res.dll 5.2.3790.3959 C:\WINDOWS\system32
039d0000 PDFShell.NLD 8.0.0.0 C:\Program Files (x86)\Common Files\Adobe\Acrobat\ActiveX
10000000 libeay32.dll 0.9.8.8 C:\Program Files (x86)\FlashFXP
4b3c0000 MSCTF.dll 5.2.3790.3959 C:\WINDOWS\SysWOW64
4dc30000 msctfime.ime 5.2.3790.3959 C:\WINDOWS\system32
4df10000 audiodev.dll 5.2.3810.3997 C:\WINDOWS\SysWOW64
4ea20000 WMVCore.DLL 10.0.0.3997 C:\WINDOWS\SysWOW64
58dd0000 WMASF.DLL 10.0.0.4000 C:\WINDOWS\SysWOW64
5f120000 ntlanman.dll 5.2.3790.3959 C:\WINDOWS\System32
5f860000 NETUI1.dll 5.2.3790.0 C:\WINDOWS\System32
5f8a0000 NETUI0.dll 5.2.3790.0 C:\WINDOWS\System32
71bb0000 wsock32.dll 5.2.3790.0 C:\WINDOWS\system32
71bc0000 rdpsnd.dll 5.2.3790.0 C:\WINDOWS\system32
71bd0000 MPR.dll 5.2.3790.3959 C:\WINDOWS\syswow64
71bf0000 WS2HELP.dll 5.2.3790.1830 C:\WINDOWS\system32
71c00000 WS2_32.dll 5.2.3790.3959 C:\WINDOWS\system32
71c40000 NETAPI32.dll 5.2.3790.3959 C:\WINDOWS\syswow64
73070000 winspool.drv 5.2.3790.3959 C:\WINDOWS\system32
75360000 CRYPTUI.dll 5.131.3790.3959 C:\WINDOWS\syswow64
75e60000 apphelp.dll 5.2.3790.3959 C:\WINDOWS\system32
75e90000 drprov.dll 5.2.3790.1830 C:\WINDOWS\System32
75ea0000 davclnt.dll 5.2.3790.3959 C:\WINDOWS\System32
75eb0000 browseui.dll 6.0.3790.3959 C:\WINDOWS\SysWOW64
76190000 MSASN1.dll 5.2.3790.3959 C:\WINDOWS\syswow64
761b0000 crypt32.dll 5.131.3790.3959 C:\WINDOWS\syswow64
762b0000 comdlg32.dll 6.0.3790.3959 C:\WINDOWS\syswow64
76520000 CSCDLL.dll 5.2.3790.3959 C:\WINDOWS\System32
768f0000 ntshrui.dll 6.0.3790.3959 C:\WINDOWS\system32
76920000 USERENV.dll 5.2.3790.3959 C:\WINDOWS\system32
76aa0000 winmm.dll 5.2.3790.3959 C:\WINDOWS\system32
76b70000 PSAPI.DLL 5.2.3790.3959 C:\WINDOWS\system32
76bb0000 WINTRUST.dll 5.131.3790.3959 C:\WINDOWS\syswow64
76c10000 imagehlp.dll 5.2.3790.3959 C:\WINDOWS\syswow64
76ed0000 DNSAPI.dll 5.2.3790.4238 C:\WINDOWS\system32
76f00000 wtsapi32.dll 5.2.3790.3959 C:\WINDOWS\system32
76f10000 WLDAP32.dll 5.2.3790.3959 C:\WINDOWS\syswow64
76f70000 winrnr.dll 5.2.3790.3959 C:\WINDOWS\System32
76f80000 rasadhlp.dll 5.2.3790.3959 C:\WINDOWS\system32
77010000 COMRes.dll 2001.12.4720.3959 C:\WINDOWS\system32
770e0000 SETUPAPI.dll 5.2.3790.3959 C:\WINDOWS\system32
771f0000 WINSTA.dll 5.2.3790.3959 C:\WINDOWS\system32
77670000 ole32.dll 5.2.3790.3959 C:\WINDOWS\syswow64
777b0000 CLBCatQ.DLL 2001.12.4720.3959 C:\WINDOWS\system32
77980000 shdocvw.dll 6.0.3790.3959 C:\WINDOWS\SysWOW64
77b00000 cscui.dll 5.2.3790.3959 C:\WINDOWS\System32
77b90000 version.dll 5.2.3790.1830 C:\WINDOWS\syswow64
77ba0000 msvcrt.dll 7.0.3790.3959 C:\WINDOWS\syswow64
7c8d0000 shell32.dll 6.0.3790.4184 C:\WINDOWS\syswow64
7d4c0000 kernel32.dll 5.2.3790.4062 C:\WINDOWS\syswow64
7d600000 ntdll.dll 5.2.3790.3959 C:\WINDOWS\system32
7d800000 GDI32.dll 5.2.3790.4237 C:\WINDOWS\syswow64
7d8d0000 Secur32.dll 5.2.3790.3959 C:\WINDOWS\syswow64
7d930000 user32.dll 5.2.3790.4033 C:\WINDOWS\syswow64
7da20000 RPCRT4.dll 5.2.3790.4115 C:\WINDOWS\syswow64
7db30000 mswsock.dll 5.2.3790.3959 C:\WINDOWS\System32
7dbd0000 comctl32.dll 6.0.3790.3959 C:\WINDOWS\WinSxS\WOW64_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.3790.3959_x-ww_5FA17F4E
7dee0000 IMM32.DLL 5.2.3790.3959 C:\WINDOWS\system32
7df50000 UxTheme.dll 6.0.3790.3959 C:\WINDOWS\system32
7e020000 SAMLIB.dll 5.2.3790.3959 C:\WINDOWS\System32

disassembling:
[...]
00568f85 lea eax, [ebp-$c]
00568f88 push eax
00568f89 lea eax, [ebp-$10]
00568f8c push eax
00568f8d mov ecx, [ebp-8]
00568f90 mov edx, ebx
00568f92 mov eax, esi
00568f94 call -$2b4cd ($53dacc) ; SBPEM.Decode
00568f99 mov ebx, eax
00568f9b 3895 test ebx, ebx
00568f9d jz loc_569013
00568f9f 3897 sub ebx, $1d02
00568fa5 jnz loc_568fca
00568fa7 3899 lea edx, [ebp-$30]
00568faa mov eax, $565c14
00568faf call -$162f44 ($406070) ; System.LoadResString
00568fb4 mov ecx, [ebp-$30]
00568fb7 mov dl, 1
00568fb9 mov eax, [$565a94]
00568fbe call -$bfc3f ($4a9384) ; SBUtils.ESecureBlackboxError.Create
00568fc3 > call -$16553c ($403a8c) ; System.@RaiseExcept
00568fc8 jmp loc_569013
00568fca 3901 lea edx, [ebp-$30]
00568fcd mov eax, $565be4
00568fd2 call -$162f67 ($406070) ; System.LoadResString
00568fd7 mov ecx, [ebp-$30]
00568fda mov dl, 1
00568fdc mov eax, [$565a94]
00568fe1 call -$bfc62 ($4a9384) ; SBUtils.ESecureBlackboxError.Create
00568fe6 call -$16555f ($403a8c) ; System.@RaiseExcept
00568feb jmp loc_569013
00568fed 3907 push ebx
00568fee lea eax, [ebp-8]
00568ff1 mov ecx, 1
00568ff6 mov edx, [$4a8a50]
00568ffc call -$1634e1 ($405b20) ; System.@DynArraySetLength
00569001 add esp, 4
00569004 3908 mov edx, [ebp-8]
00569007 mov eax, esi
00569009 mov ecx, ebx
0056900b call -$1664dc ($402b34) ; System.Move
[...]

Thank you for your bug report.

I suspect there might be a problem with the certificate type detection routines, I made some changes that should resolve the problem you experienced. In my tests it appears that some cer type certs were detected as der which resulted in failure.

Here's a build you can test with
http://download.flashfxp.com/beta/ffxp3.7.2.1268.zip

I happen to have a .p12 cert for testing and it imported without issues. I'm not really sure why yours could of failed, Unless it was related to the above issue.

Additional licenses can always be purchased later. Typically for single licenses we issue separate keys for each copy of FlashFXP, if you purchase several keys at once they're consolidated into a single key to make managing them easier. This of course is done on a per-purchase basis so if you already have one key will be always be separate from any new keys you purchase.

Ok I tested this with .pem files. That is working good now Also the replace is ok!

Just one little thing:

When I open the cert manager and replace the cert, the current site is automatically set to (none) for client cert (even if it had one). But if it had a cert, it's internally actually still ok (still having the cert when I re-open site manager).
So it's more something that could confuse, but for the rest great work!

I also tested a p12 file, since a p12/pfx file contains both the private and the public key, I tried several combinations to put the p12 file. (selected it for cert/pvk or both)
Always got the error: unable to load the private key. I tested the same cert in the windows cert manager and it imports fine, so I'm sure the password and cert are correct.
For me this is not an issue, since I rarely use it. But I'm still curious if it's me, or a little bug left

Oh, yes!
The bug that after click I Accept buttom the main window can't active has also been fixed!

Thanks so much
Love FlashFXP
rxzcums

Originally Posted by JGOe2s

Just one little thing:

When I open the cert manager and replace the cert, the current site is automatically set to (none) for client cert (even if it had one). But if it had a cert, it's internally actually still ok (still having the cert when I re-open site manager).
So it's more something that could confuse, but for the rest great work!

I missed this in my last build, here's the fix
http://download.flashfxp.com/beta/ffxp3.7.2.1269.zip

Ok, thank you, it works as expected now