Go Back   FlashFXP Forums > >

Project: FlashFXP Bug Reports Ticket Tools
ID: 717 Category: FlashFXP Bug
Title: Delete file in queue Status: Closed (Fixed / Implemented)
Severity: Minor Version: 4.2 stable

Junior Member
buli1976
05-23-2012, 01:27 PM
Delete file in queue

When i add file (file is located on HDD to my lan ftp) to queue and delete file via CTRL+DEL to queue flashfxp stops after first delete and dont process next items in queue. Also if delete file is last item in queue (for example transfer file X to ftp and delete file X) and check in menu Session --> On Transfer Complete --> Quit FlashFXP program dont close, only stop and disconnect from site.
This behavior appear in 4.2 i think. In 4.1 was OK.
FlashFXP Developer
bigstar
05-23-2012, 03:16 PM
Re: Delete file in queue

Hello,

Thank you for bringing this to our attention.

I have reproduced the issue, I will put it on my TODO list and get it fixed in the next couple days.

I can provide you with an updated build as well.
FlashFXP Developer
bigstar
05-23-2012, 04:26 PM
Re: Delete file in queue

Please try the following dev build

https://oss.azurewebsites.net/testr/ffxp4.2.3.1772.zip


Unzip the flashfxp.exe into your FlashFXP program folder.
Junior Member
buli1976
05-24-2012, 10:01 AM
Re: Delete file in queue

Thank You for fast response.
I tried dev version and some strange behaviour occur.
I put in queue:
file x ---> to my LAN ftp site
delete x
file y ---> to my LAN ftp site
delete y

After delete file x got error 'Connection failed' in log window and program 'Delaying for 120 seconds before reconnect '. After 2 mins. connect to my site again and finish last two items from queue.

Regards
FlashFXP Developer
bigstar
05-24-2012, 07:16 PM
Re: Delete file in queue

https://oss.azurewebsites.net/testr/ffxp4.2.3.1773.zip


It appears that my changes created a race condition, Here's another update for you to try.

In addition to fixing the race condition I changed the behavior of FlashFXP to not disconnect from the remote server when performing a queued local delete operation.
Junior Member
buli1976
05-25-2012, 09:55 AM
Re: Delete file in queue

Thanks bigstar!
Now works fine. However i perform reverse test with above example
I put in queue:
file x from LAN ftp site ---> to my hdd
delete x
file y from LAN ftp site ---> to my hdd
delete y

Program process queue and left items with deletion. Obviously files was deleted from my site.
Maybe You should check that also

Kind Regards.
FlashFXP Developer
bigstar
05-26-2012, 01:49 PM
Re: Delete file in queue

Can you please post a copy of the session status log.

I did some tests but I was unable to reproduce the problem, perhaps FlashFXP isn't correctly detecting that the server successfully deleted the file.
Junior Member
buli1976
05-27-2012, 06:48 AM
Re: Delete file in queue

OK, here is:

FlashFXP 4.2.3 (build 1773)
Support Forums http://forum.flashfxp.com
Winsock 2.2 -- OpenSSL 1.0.1c 10 May 2012
[R] Connecting to NMT -> IP=192.168.1.15 PORT=2223
[R] Connected to NMT
[R] 220 --- Networked Media Tank FTP server (LundFTPD 3.17 build 512 +TLS +LiON Sun May 27 13:31:36 2012) ready.
[R] USER nmt
[R] 331 Password required for nmt.
[R] PASS (hidden)
[R] 230- [ LOGIN ]
[R]
[R] Welcome to --- Networked Media Tank , nmt! This is your 226th visit.
[R] You last logged in at Sun May 27 13:29:43 2012 from NONE@192.168.1.10
[R] SYST
[R] 215 UNIX Type: L8 Version: hard2get
[R] FEAT
[R] 211-Features supported
[R] MDTM
[R] REST STREAM
[R] SIZE
[R] PRET
[R] AUTH TLS
[R] CCSN
[R] SSCN
[R] XDUPE (Disabled)
[R] 211 End
[R] PWD
[R] 257 "/" is current directory.
[R] CWD /SATA_DISK/Video
[R] 250-Available space: 711343.44 MB.
[R] 250 CWD command successful.
[R] PWD
[R] 257 "/SATA_DISK/Video/" is current directory.
[R] TYPE A
[R] 200 Type set to A.
[R] Listening on PORT: 54676, Waiting for connection.
[R] PORT 192,168,1,10,213,148
[R] 200 PORT command successful.
[R] LIST -al
[R] 150 Opening ASCII mode data connection for /bin/ls.
[R] 226 Transfer complete.
[R] List Complete: 16 KB in 0,23 second (16,9 KB/s)
[R] Calculating timezone offset of server...
[R] MDTM CCEnhancer-2.5.1.exe
[R] 213 20120527113048
[R] Timezone offsets: Server: 7200 seconds. Local: 7200 seconds. Difference: 0 seconds.
[R] TYPE I
[R] 200 Type set to I.
[R] SIZE CCEnhancer-2.5.1.exe
[R] 213 283136
[R] MDTM CCEnhancer-2.5.1.exe
[R] 213 20120527113048
[R] PORT 192,168,1,10,213,149
[R] 200 PORT command successful.
[R] RETR CCEnhancer-2.5.1.exe
[R] 150 Opening BINARY mode data connection for CCEnhancer-2.5.1.exe (283136 bytes).
[R] 226 Transfer complete.
Transferred: CCEnhancer-2.5.1.exe 276 KB in 0,03 second (276,5 KB/s)
[R] DELE /SATA_DISK/Video/CCEnhancer-2.5.1.exe
[R] 257 DELE command successful.
[R] SIZE IE9-WindowsVista-x64-plk.exe
[R] 213 1248048
[R] MDTM IE9-WindowsVista-x64-plk.exe
[R] 213 20120527113044
[R] PORT 192,168,1,10,213,150
[R] 200 PORT command successful.
[R] RETR IE9-WindowsVista-x64-plk.exe
[R] 150 Opening BINARY mode data connection for IE9-WindowsVista-x64-plk.exe (1248048 bytes).
[R] 226 Transfer complete.
Transferred: IE9-WindowsVista-x64-plk.exe 1,19 MB in 0,12 second (1,19 MB/s)
[R] DELE /SATA_DISK/Video/IE9-WindowsVista-x64-plk.exe
[R] 257 DELE command successful.
Transfer queue completed
Transferred 2 Files (1,46 MB) in 0,43 second (1,46 MB/s)


As You see nothing usual, but these two entries with delete still exists in queue. I tried also with other random files for sure.
Link for screenshot:
http://imageshack.us/photo/my-images...ztytuucaa.jpg/
FlashFXP Developer
bigstar
05-28-2012, 07:13 AM
Re: Delete file in queue

Thank you very much for the session log and screenshot.

I discovered the problem

It appears that the FTP server returns a non-standard RFC reply code 257 to indicate delete successful.

The reply code should be 250.

I will adapt the code to accept 257 as a valid successful reply.

Please give me a day or two and I will post an updated dev build for you to test.
FlashFXP Developer
bigstar
05-28-2012, 11:03 AM
Re: Delete file in queue

I updated the code to accept 257 as a valid reply to the delete operation.

You can grab the dev build at
https://oss.azurewebsites.net/testr/ffxp4.2.3.1774.zip
Junior Member
buli1976
05-28-2012, 01:31 PM
Re: Delete file in queue

Now works perfect! Thank You very much!

Kind Regards.
FlashFXP Developer
bigstar
05-29-2012, 11:13 AM
Re: Delete file in queue

Thanks for testing and letting me know that the issue is now fixed.

We will incorporate these changes into the next public release.
Ticket Tools
Subscribe to this Ticket


Posting Rules
You may not post new tickets

Smilies are On
[IMG] code is On
HTML code is Off


All times are GMT -5. The time now is 11:55 AM.

Parts of this site powered by vBulletin Mods & Addons from DragonByte Technologies Ltd. (Details)