Go Back   FlashFXP Forums > > > >

Harm's scripts ioBanana, Readd script, ioVote

Reply
 
Thread Tools Rate Thread Display Modes
Old 01-23-2004, 08:08 PM   #1
Mouton
Posse Member
Ultimate Scripter
ioFTPD Administrator
 
Join Date: Dec 2002
Posts: 1,956
Default ioB zs bug on APPE

I dunno if other zipscripts does same as ioB, so i post public in case other zs authors wanna check their work.

Situation:

client1 sends a file.
ioFTPD has pre_allocation activated to let's say 1024... file size increase by 1024kB during the upload. Say this file is 50MB.

After half the file is sent, client2 list that dir. It sees the file as being 25MB.

client1 finishes sending the 50MB file. file is ok, and zs mark it as good (in it's .race file).

client2, without refreshing the dir list, tries to upload that same file. client2 uses APPE (file resuming).

since client2 thinks the file is 25MB, it will issue a APPE filename command, and will send the content of the file, starting at 25MB...
Resulting file is 75MB and is, u should have guessed, bad.

ioB zs bug: when a file is sent, and marked as ok, subsequent OnUploadComplete events called for that same file, wheter it's good or bad, will result in a "Next time you overwrite a perfectly good file, you'll get your balls ripped off!!!" and the file not being processed.

Harm: just commenting the whole '// Check if that file was already upped and ok..?' section should fix it, since the second call to OnUploadComplete is made with a bad CRC value.

Other ppl: u might wanna put APPE = M and REST = M on your ioFTPD.ini [FTP_Command_Permissions] section... just in case some ppl wanna resume files they send on your site, and u don't want them to... I also changed Upload_PreAllocation back to 0, just as a precaution...
Mouton is offline   Reply With Quote
Old 01-23-2004, 08:26 PM   #2
Zer0Racer
Senior Member
ioFTPD Scripter
 
Join Date: Oct 2002
Posts: 703
Default

This is a perfect post I would say. Thanks for quick fix too. :i'm not gonna use the dancing banana:
Zer0Racer is offline   Reply With Quote
Old 01-23-2004, 08:30 PM   #3
Mouton
Posse Member
Ultimate Scripter
ioFTPD Administrator
 
Join Date: Dec 2002
Posts: 1,956
Default

let me just fix vbb settings so ":i'm not gonna use the dancing banana:" shows the banana....

*edit: hahaha seems like ":i'm not g " is the longest possible string for a smilie! :)
Mouton is offline   Reply With Quote
Old 01-23-2004, 08:36 PM   #4
Zer0Racer
Senior Member
ioFTPD Scripter
 
Join Date: Oct 2002
Posts: 703
Default

w00t

hehehe
Zer0Racer is offline   Reply With Quote
Old 01-24-2004, 03:43 AM   #5
Harm
Too much time...
Ultimate Scripter
 
Join Date: Jul 2003
Posts: 1,430
Default

Ok, I will do that.

I thought the uploaded files appear to be 0bytes until the transfer completes (unless you flush the dir cache).

FlashFXP uses the SIZE command before APPE/REST.
Does the wrong answer come from the directory cache ?
Harm is offline   Reply With Quote
Old 01-24-2004, 10:15 AM   #6
Mouton
Posse Member
Ultimate Scripter
ioFTPD Administrator
 
Join Date: Dec 2002
Posts: 1,956
Default

Could be. Yould have to sniff packets to know what happens exactly. I only know that non-valid files bigger than they should be were marked as valid.
Mouton is offline   Reply With Quote
Old 01-25-2004, 04:57 PM   #7
ViNcE
Junior Member
 
Join Date: May 2003
Posts: 25
Default

True... i got the same problem with my own sfv checker that will be released soon maybe.. i don't know yet..

But anyway, for my case, the file was 2 time in my race file and ioFTPD told to zipscript that file was complete 2 times.. (and marked as good)

I think the best way is like Mouton said, to disable resuming...

Darkone should show file size in realtime.. that should fix most of the problems... but i dunno if that is possible now with the dir caching...

Anyway guys.. have fun

Bye!
ViNcE is offline   Reply With Quote
Reply

Tags
appe, client2, file, iob, upload

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Compare Folder Content -- SUBDIRS too? dgrrr General Discussion 1 04-04-2005 08:28 PM


All times are GMT -5. The time now is 02:16 AM.

Parts of this site powered by vBulletin Mods & Addons from DragonByte Technologies Ltd. (Details)