ioFTPD v7.3.3 Released (Beta)

[Yil]

zero: The exec module actually changed quite a bit between v6.9 and v7.0 because it started supporting keep-alive timeouts and that required a number of changes. I don't think the conditions for deleting a file after upload changed though. After the changes I fixed a few things and tested with ioZS and ioA/B which I believe both work fine now. Which zipscript is failing?

I'll take a look at the symlink crash though. Have you left Keep_Links_In_Paths enabled? For kicks, switch it off, rehash, re-login, and see if it makes a difference in resolving.

[o_dog]

is it just me having trouble with "426 Data connection: Broken pipe." site just hangs in uploda and i have to hard abort then reupload, it doesn't time out as it should. Dunno what tha hell is going on or if it's my link

After the timeout it tries to transfer the rest of the files and I get:
550 Active transfer in progress, terminate transfer with ABOR before proceeding.
and it aborts the transfer.

whats going on?

[Yil]

o_dog: Could you send me an FTP log starting from just before where it gets confused? I can see cases where maybe the client gets confused, but that 550 message means the server thinks it's still got a transfer going and that's kinda weird. It does mean you can use "site crashnow" to generate a dump I can debug if you can find a time where the server is otherwise idle.

I'm getting the next minor release with just a few simple things in it ready, but it won't be for a day or so.

[Zer0Racer]

Originally Posted by Yil

zero: The exec module actually changed quite a bit between v6.9 and v7.0 because it started supporting keep-alive timeouts and that required a number of changes. I don't think the conditions for deleting a file after upload changed though. After the changes I fixed a few things and tested with ioZS and ioA/B which I believe both work fine now. Which zipscript is failing?

I'll take a look at the symlink crash though. Have you left Keep_Links_In_Paths enabled? For kicks, switch it off, rehash, re-login, and see if it makes a difference in resolving.

It's a modified version of Project-ZS for ioFTPD. Exactly what changes are required?

Changing any of the EXEC related settings in ioFTPD.ini doesn't help in this case? I've tried but with no luck.

With Keep_Links_In_Paths = False it's still crashing when I try to create a symlink manually with site symlink. Using site chattr +l manually still works. No change for the valid link that the zipscript creates. Though I guess it could be a result of the incompatibility with v7.x.

/ZR

[monk-]

Keep_Links_In_Paths = False did the trick for me, entering symlinks now show as they used to, with full path

i also have the problem that warchive only runs manualy:
[R] site warchive
[R] 200-- WarChive ------------------------------------------------------------------
[R] 200-Current free space: 0
[R] 200-Deleting: 0325
[R] 200-Printed putlogline
[R] 200--!putlog WARCWIPE: "0325" "43396.04" "/XXX/" "0.00" "43408.00"
[R] 200-Enough space free on device
[R] 200-Current free space: 330155
[R] 200-Enough space free on device
[R] 200-Current free space: 18404
[R] 200-Enough space free on device
[R] 200------------------------------------------------------------------------[1.4]-

but on schedule returns the error:
04-06-2010 17:11:53 Scheduler event 'warchive' returned error.

this is since 7.0.x, prolly also some EXEC module problem

[Yil]

Zero: there shouldn't be any changes required. However, can you tell if the modified Project-ZS tries to use ! commands like !vfs:add, !putlog, etc. It's possible that it's using one of these that I didn't port correctly and that's causing the errors. If the zipscript is easy to install I'll do that and figure out the problem locally so just PM me about how to get it, or send it to me.

monk: Do you not get that scheduler event returned error message on v6.x releases? Did warchive actually do what it was supposed to when run? If so then it's usually because the process returned a non-zero exit code, and we'll have to figure out why... I can already see the -!putlog line from your example and the leading - I don't think belongs there. That shouldn't cause any issues but it probably isn't going to do anything...

[Yil]

I forgot to zero out the Overlapped structure in the exec module before re-using it. So if the server didn't read the input all in at once it would sometimes generate an error. This might fix both issues. Working on the rest of the fixes for the next release should be done tonight or tomorrow.

[Zer0Racer]

Yil, just sent you a PM. Maybe you won't have to try the zipscript if the next release is the solution. Will try it as soon as it will become available. Thanks.

[Yil]

v7.3.1 Release Notes:

1) Files in \System:
   Changed : ioFTPD.[exe,pdb] - Version 7.3.1.0.
   Added   : ioFTPD-Watch.exe - Version 1.0.0.0.
   Changed : ioFTPD.ini - summary of changes by section...
     [Threads] : Restart_On_Deadlock added.


*** New Features

2) New ioFTPD.ini option (Restart_On_Deadlock under [Threads]).  If this
   is enabled the server will start the child process ioFTPD-Watch.exe and
   signal it when it thinks the server has locked up so it can terminate
   the server since it cannot do it itself when the loader lock has been
   compromised.  When run as a service it can be configured to automatically
   restart.  (The ServiceInstaller.exe tool by default configures it to
   auto-restart provided it hasn't crashed within the last 10 minutes).

3) If the server is preloading directories or running a recursive action
   through a directory tree and the server begins shutting down the operation
   will now abort.


*** Bug Fixes

4) Fixed a bug with resolving relative symbolic links (../foo) where the
   last component of the symbolic directory path was being removed before
   following the link when it shouldn't have been.  The non-symbolic path
   was be updated correctly though.

5) Fixed a bug in "site symlink" introduced when attempting to preserve the
   alternate timestamp / upload speed fields added in v7.2 but referenced the
   wrong fileinfo structure.

6) Fixed a bug in the EXEC module where I wasn't zeroing out the Overlapped
   structure before re-using it.  This would cause it to sometimes generate
   an error.

7) Fixed a bug where an Event handle created in the EXEC module wasn't being
   closed.

8) Fixed a bug in login code that would cause crashes during logout if the
   userfile was unable to be locked during login.  This can only happen if
   using a shared user module and even then it shouldn't happen.

9) Fixed a potential race condition on some bits in a bit field used by the
   data transfer code.  In theory if a transfer is aborted in some situations
   it's possible that 2 threads may be changing 2 different bits but because
   these are bit fields require a read/modify/write sequence they aren't
   atomic operations.  I simply moved the 1 bit that can be set by more than
   1 thread out of the bitfield.


*** Debugging Only Changes:

10) 2 new Error logfile entries to catch problems during logoff that should
   no longer be possible with the bugfix above.
    * Supposedly logged in user missing userfile!
    * Client structure identifies user as logged in but no userfile: %d

11) New Error logfile entry if a userfile cannot be locked.

12) New debug logfile entry if the server attempts to cancel an internal
    async select and it appears that it may have already had activity.

13) New debug logfile entry if the timeout function for connected sockets
    shows a previous error.  Not all errors recorded here are things to
    worry about, some may be valid and will be excluded in later releases.


*** Internal non-visible changes:

14) Moved setting socket to non-lingering after disconnect from the socket
    close routines to right after creation just in case that helps.

[Yil]

Link to new version: See top of thread, a new version is out.

Let me know what's still broken.

[Yil]

v7.3.2 Release Notes:

1) Files in \System:
   Changed : ioFTPD.[exe,pdb] - Version 7.3.2.0.


*** Bug Fixes

2) Forgot to remove a line of code used when trying to get the server to
   act like it locked up to see if I could get the window's service control
   manager to restart it.

[Yil]

Link to new version: ioFTPD-v7.3.2.zip

[monk-]

what is Restart_On_Deadlock 's default option?
cos if this workarrounds the lockup bug, i say TRUE
anyway, nice release, im gonna test a bit, thx

[Yil]

monk-: It defaults to false, you have to enable it.

[pion]

I can confirm that the lockup bug is indeed still present in 7.3.2. The process didn't appear to implode, and io refused to accept connections