Command Line Bug if present an ";" in the path

[ture82]

Command Line Bug if present an ";" in the path

while running Flashfxp with command line
FlashFXP.exe ftp://userass@hostort/path
if the path contain a ";" it stops reading path.

i supposed becaouse FlashFXP use ; as separator
for two SIte Command Line as help :

For two sites
FlashFXP.exe ftp://userass@hostort/path;ftp:...@hostort/path
bye

Ture


* FlashFXP v[3 ].[0 ], build [1010 ], [ ]registered, [x ]unregistered, [ ]pirated
* OS [ x] WinXP, [ ] Win2K, [ ] Win98, [ ] WinME, [ ] Other
* Running behind NAT/router [ ] Yes & Model [ ], [x ] No, [ ] Not sure
* Running firewall [ ] Yes, Name [ ], Ver. [ ], or [x ] No
* Running Antivirus [ ] Yes, Name [ ] or [ x] No
* Network [ x] xDSL, [ ] CABLE, [ ] Dail-Up, [ ] Other

additional info if related
* FTP server(s) name [ ], version [ ]
* timestamped, and side prefixed FTP log (please paste)
* any other info

[bigstar]

Thank you for your bug report.

Unfortunately this is a design limitation.

FlashFXP does not support the use of ; in the command line unless it's being used to seperate two ftp sites.

[ture82]

i suggest to use charracters that are invalid for path
like <> or ""

the command line coul be

flashfxp.exe "ftp://userass@host/path"

or flashfxp.exe <ftp://userass@host/path>

for two site:

flashfxp.exe "ftp://userass@host/path";"ftp://userass@host/path"

in this way it is possible to use ; in path

bye

Ture

[bigstar]

The ; character is not commonly used in folder paths.

However the scope of the problem is much greater than just folder paths. When a ftp:// url or a site manager entry name is passed, any part of that value containing the seperator character is going to run into problems.

Sometime down the road this may be changed but for the immedate future using the ; character will remain.

[ture82]

Sorry but i do not understand where is the problem to add this little check.... as i see FlashFXP is write in Delphi...

as i am a delphi developer too, i think it's very simple to add that check.

just scan the ParamStr(0) as string char by char


Starting at the first occurance of " normaly the first characterst
until the next occurance of " --> this is the Path.

little code:

var str:string;
i,j:integer;
str:=paramStr(0);

for i:=1 to length(str) do
if str[i]='"' then break;

for j:=i+1 to length(str) do
if str[j]='"' then break;

Path:=midstr(str,i+1,j-i-1);


Best Regards

Ture

[bigstar]

I'm sorry but FlashFXP is in a code freeze because we're about to release the final version. Alternative solutions will be considered after we release FlashFXP v3.0.

Our command line handling is too complicated for your simple code suggestion. The use of quotes may not be the ideal solution because a " may appear more often in site names then a ;


------

Just a crazy idea but I think you could escape the ftp path using % escape codes.. Just like you would use %20 for a space. I'm not sure what the excape code is for ; though.

[ture82]

ok your solution works!

i replace ; with %3B th escape code, it works!!

thanks

Bye

Ture