OnUploadComplete

[SnypeTEST]

got this problem, ioftpd.exe running OnUploadComplete more than 1 time for 1 file.

I made an exe that would print "!putlog $filename". while simulating a 7User Race on my lan, got this in ioftpd.log

* only pasting the doubles that appeared *

09-24-2003 20:11:18 10-50_cent-the_blast_(feat._g-unit)_(freestyle)-osc.mp3
09-24-2003 20:11:18 10-50_cent-the_blast_(feat._g-unit)_(freestyle)-osc.mp3
09-24-2003 20:11:18 11-50_cent-your_after_my_chedda_(feat._g-unit)_(freestyle)-osc.mp3
09-24-2003 20:11:18 11-50_cent-your_after_my_chedda_(feat._g-unit)_(freestyle)-osc.mp3

my ioftpd thread settings are
Worker_Thread_Min = 5 # Minimum amount of worker threads
Worker_Thread_Max = 10 # Maximum amount
Io_Thread_Count = 3 # Io Threads

before I had min = 10 , max = 20 , threadcount = 6 , then I tired lower value, same prob.

using ioftpod 5.0.13

[Events]
;OnFtpNewDir = ..\newdir\newdirlog.itcl
OnFtpDelDir = ..\psio\pSio.exe DELDIR
;OnUploadComplete = iotrial.exe UD
OnUploadComplete = ..\psio\pSio.exe UD
;OnUploadError =
;OnUploadComplete =
;OnDownloadError =
;OnDownloadComplete =
;OnResume =
;OnUpload =
;OnFtpNewDir =
;OnFtpDelDir =
;OnFtpLogIn =
;OnTelnetLogIn =
;OnHttpLogIn =
;OnServerStart =
;OnServerStop =

[SnypeTEST]

Also tried it with a .bat file onuploadcomplete.

start bat file
=========
@echo off
@echo !putlog %1
=========
end bat file

output to log:

09-24-2003 20:58:57 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-osc.sfv"
09-24-2003 20:58:58 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-osc.nfo"
09-24-2003 20:58:58 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-osc.nfo"
09-24-2003 20:58:58 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-(back_cover)-osc.jpg"
09-24-2003 20:58:58 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-(back_cover)-osc.jpg"
09-24-2003 20:58:59 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-(front_cover)-osc.jpg"
09-24-2003 20:58:59 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-(front_cover)-osc.jpg"
09-24-2003 20:58:59 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-osc.m3u"
09-24-2003 20:58:59 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\00-50_cent-gangster_and_a_gentleman_(part_1)-2003-osc.m3u"
09-24-2003 20:58:59 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\01-50_cent-wnta_mixtape_radio_concert_intro-osc.mp3"
09-24-2003 20:59:00 "k:\ioFTPD\site\MP3\50_Cent-Gangster_and_A_Gentleman_(Part_1)-2003-OSC\01-50_cent-wnta_mixtape_radio_concert_intro-osc.mp3"

see jpg/nfo/and mp3 file doubled..

[GOD-EMPEROR]

just fyi, if you @echo off.... you don't have to add @ to echo the text.... likewise if you use @echo text then you don't to turn echo off heh

[SnypeTEST]

d1, you havent noticed this post yet :confused: , bug still exist in b51x btw.

[Mouton]

my guess:
related to the OnUploadComplete being executed on ABORT.
Thus your OnUploadComplete being execute for the uploaded file, and for the cancelled upload when another thread tried uploading same file...
but dark: that would mean that the bug isn't on abort only ..? Or maybe Snype hit abort a couple of times...?

[SnypeTEST]

Mouton, I just ran ultrafxp , connect 6 times and upload files from the same folder to simulate a race. the .bat file captures more doubles than the sample .exe I was using, maybe because it executed faster though.

[darkone]

Are you sure it runs script twice? or could it be that log is written twice?

[SnypeTEST]

well it only has 1 line of code that write to log...

echo !putlog %1

:-/ the only way it could do it twice for the same file in the same dir is if its ran twice onuploadcomplete... well anyway, for new psio (my zipscript) , I just pre-check to see if file was already checked to get rid of duplicates... also, Bad|'s script doesnt work on ioftpd b5xx because of this bug.

[darkone]

Can't you try..?

@echo %1 > c:\dump

[b>d>>s]

i just tried above .bat on 513r and the uploaded file disappears and no dump.

i have exactly what you put above OnUploadComplete, works on 494r :/

[b>d>>s]

i added 'exit 0', same result as above :/

[darkone]

You did remember to use EXEC before your test bat?

[b>d>>s]

aaaaaaaaaaah, shit. no. 2 secs ........

[b>d>>s]

oooooooooooooow, so this is what i get in dump, a bit odd.


"d:\\Big-Midi-Packs-&-Twiddly-Bits\mas.nfo"



double \ ?

and console i get (on completion).


150 Opening ASCII mode data connection for mas.nfo.
226-D:\ioFTPD\system>exit 0

[darkone]

It might use two '\' chars if you're using uploading to drive's root... :I

[b>d>>s]

i wasnt uploading to drives root , root is d:\, dir i uploaded to was d:\Big-Midi-Packs-&-Twiddly-Bits\

which pre-existed on the drive (wasnt created in upload).